Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Date
Msg-id 20140526173131.GA11572@awork2.anarazel.de
Whole thread Raw
In response to Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD  (Matteo Beccati <php@beccati.com>)
List pgsql-hackers
On 2014-05-26 13:25:49 -0400, Tom Lane wrote:
> Matteo Beccati <php@beccati.com> writes:
> > I'm attaching v2 of the patch. Here's a list of changes from v1:
> 
> > * Restored --with-ossp-uuid. Configure tries ossp support first, then
> > falls back to Linux and BSD variants

Imo should be the other way round.

> > * md5.o and sha1.o are linked only when not using the ossp library

The backend already has a md5 implementation, no?

> Assuming this works as advertised, does anyone have an objection to
> pushing it into 9.4?

I think it's a pretty bad idea. But the alternatives seem worse. We
should better get it right though if we do it.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Next
From: Jeff Janes
Date:
Subject: Re: Allowing line-continuation in pgbench custom scripts