Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Date
Msg-id 31183.1401125149@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD  (Matteo Beccati <php@beccati.com>)
Responses Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
List pgsql-hackers
Matteo Beccati <php@beccati.com> writes:
> I'm attaching v2 of the patch. Here's a list of changes from v1:

> * Restored --with-ossp-uuid. Configure tries ossp support first, then
> falls back to Linux and BSD variants
> * md5.o and sha1.o are linked only when not using the ossp library
> * fixed a bug in the v1mc generation carried over from uuid-freebsd:
> only the mac part is randomized now
> * updated regression tests, which are now passing on ubuntu w/ and w/o
> ossp and netbsd.

> This was the best I could achieve in the limited timeframe I had
> available. I believe it could be a good starting point for your final
> refactoring.

I've not reviewed this in any detail yet, but I believe we're in agreement
on the general ideas.  I do think that we need two separate configure
switches: one asking to use the OSSP library and one asking to use the
other library.  That's an easy change though.

Assuming this works as advertised, does anyone have an objection to
pushing it into 9.4?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Spreading full-page writes
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD