Re: Fixed redundant i18n strings in json - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: Fixed redundant i18n strings in json
Date
Msg-id CAMkU=1wGRVta0fCHfXy4rSTi4ew+DNxAPcjs_AOqQtUESnTtBg@mail.gmail.com
Whole thread Raw
In response to Re: Fixed redundant i18n strings in json  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Fixed redundant i18n strings in json
List pgsql-hackers
On Tue, Aug 5, 2014 at 9:35 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
<daniele.varrazzo@gmail.com> wrote:
> I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
> "argument 1: something is wrong": the string is likely to end up in
> sentences with other colons so I'd rather use "something is wrong at
> argument 1".
>
> Is the patch attached better?

Looks OK to me.  I thought someone else might comment, but since no
one has, committed.

(As a note for the future, you forgot to update the regression test
outputs; I took care of that before committing.)

I think you missed one of the regression tests, see attached

Thanks,

Jeff
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Append to a GUC parameter ?
Next
From: Peter Geoghegan
Date:
Subject: Re: B-Tree support function number 3 (strxfrm() optimization)