Re: An incorrect check in get_memoize_path - Mailing list pgsql-hackers

From Richard Guo
Subject Re: An incorrect check in get_memoize_path
Date
Msg-id CAMbWs49nbDOBo_0H6crjewDv=HxtA84rrv-70R+_yhAZom06gQ@mail.gmail.com
Whole thread Raw
In response to An incorrect check in get_memoize_path  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: An incorrect check in get_memoize_path
List pgsql-hackers
On Mon, Apr 7, 2025 at 4:50 PM Richard Guo <guofenglinux@gmail.com> wrote:
> Hence, I propose the attached patch for the fix.
>
> BTW, there is a XXX comment there saying that maybe we can make the
> remaining join quals part of the inner scan's filter instead of the
> join filter.  I don't think this is possible in all cases.  In the
> above query, 'coalesce(t2.b) = t3.b' cannot be made part of t3's scan
> filter, according to join_clause_is_movable_into.  So I removed that
> comment in the patch while we're here.
>
> Any thoughts?

Here is an updated patch with a commit message.  Regarding
backporting, I'm inclined not to, given the lack of field reports.
Any objections to pushing it?

Thanks
Richard

Attachment

pgsql-hackers by date:

Previous
From: Tender Wang
Date:
Subject: Re: MergeJoin beats HashJoin in the case of multiple hash clauses
Next
From: Dmitry Dolgov
Date:
Subject: Re: Changing shared_buffers without restart