Postgres Pro
Downloads
Home   >   mailing lists

Re: Removed unused param isSlice of function transformAssignmentSubscripts - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Removed unused param isSlice of function transformAssignmentSubscripts
Date
Msg-id CAMbWs48zXfcVeyWYHGw87GLQEvKjNqmQafhtsXB_UccXXHipYA@mail.gmail.com
Whole thread Raw
In response to Removed unused param isSlice of function transformAssignmentSubscripts  (Zhang Mingli <zmlpostgres@gmail.com>)
Responses Re: Removed unused param isSlice of function transformAssignmentSubscripts
List pgsql-hackers
Tree view

On Tue, Sep 13, 2022 at 11:35 AM Zhang Mingli <zmlpostgres@gmail.com> wrote:
Param isSlice was once used to identity targetTypeId for transformAssignmentIndirection.

In commit c7aba7c14e, the evaluation was pushed down to transformContainerSubscripts.

No need to keep isSlice around transformAssignmentSubscripts.

Attach a patch to remove it.
 
+1. Good catch.

Thanks
Richard

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Error "initial slot snapshot too large" in create replication slot
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Error "initial slot snapshot too large" in create replication slot