Re: Making Vars outer-join aware - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Making Vars outer-join aware
Date
Msg-id CAMbWs4-H7jBUpPfjDzswkRdU+43nxtmezyfAJoC9=WDyD6GwkQ@mail.gmail.com
Whole thread Raw
In response to Re: Making Vars outer-join aware  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Making Vars outer-join aware
List pgsql-hackers

On Tue, Jan 24, 2023 at 4:38 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Richard, are you planning to review this any more?  I'm getting
a little antsy to get it committed.  For such a large patch,
it's surprising it's had so few conflicts to date.
 
Sorry for the delayed reply.  I don't have any more review comments at
the moment, except a nitpicking one.

In optimizer/README at line 729 there is a query as

    SELECT * FROM a
      LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = b.y)
    WHERE a.x = 1;

I think it should be

    SELECT * FROM a
      LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = ss.y)
    WHERE a.x = 1;

I have no objection to get it committed.

Thanks
Richard

pgsql-hackers by date:

Previous
From: "wangw.fnst@fujitsu.com"
Date:
Subject: RE: Logical replication timeout problem
Next
From: Yuya Watari
Date:
Subject: Re: [PoC] Reducing planning time when tables have many partitions