Re: Making Vars outer-join aware - Mailing list pgsql-hackers

Richard Guo <guofenglinux@gmail.com> writes:
> Sorry for the delayed reply.  I don't have any more review comments at
> the moment, except a nitpicking one.

> In optimizer/README at line 729 there is a query as

>     SELECT * FROM a
>       LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = b.y)
>     WHERE a.x = 1;

> I think it should be

>     SELECT * FROM a
>       LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = ss.y)
>     WHERE a.x = 1;

Oh, good catch, thanks.

> I have no objection to get it committed.

I'll push forward then.  Thanks for reviewing!

            regards, tom lane