[pgAdmin][RM4421] Inno setup script version compare fix - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject [pgAdmin][RM4421] Inno setup script version compare fix
Date
Msg-id CAM9w-_mnD3MQBMLZdY9oKwSsu6fiwWUFY9ZZob6fPUfiormy1A@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin][RM4421] Inno setup script version compare fix  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Hackers,

Attached is the patch to fix a potential issue where version compare while upgrading will be incorrect. Currently, it is comparing strings. So while comparing '4.9' and '4.10' it will consider '4.9' as greater.
The patch will convert the values to float and compare.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM4421] Inno setup script version compare fix