Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4421] Inno setup script version compare fix - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM4421] Inno setup script version compare fix
Date
Msg-id CANxoLDdjtQK1sqmAhE4JsjdiM_5rvZnF31Po8NeDfGbmWyA8Aw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM4421] Inno setup script version compare fix  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin][RM4421] Inno setup script version compare fix  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Aditya 

I have asked Paresh to review the patch, he has given some review comments. Please fix those and the updated patch asap.  

On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix a potential issue where version compare while upgrading will be incorrect. Currently, it is comparing strings. So while comparing '4.9' and '4.10' it will consider '4.9' as greater.
The patch will convert the values to float and compare.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: [pgAdmin][RM4421] Inno setup script version compare fix
Next
From: Dave Page
Date:
Subject: Re: RE-SQL tests for Roles & Resource Group nodes