Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][Patch]: Wrong listing of directories in File Manager in Windows Only. - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][Patch]: Wrong listing of directories in File Manager in Windows Only.
Date
Msg-id CAM5-9D9+eq8auZ9SVOhU12xtTy29YaGSHitHfyTNfXocTK+gdw@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: Wrong listing of directories in File Manager in Windows Only.  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi

Issue:
FileManager: when Select File dialog is opened in query tool in Runtime Mode, it was listing wrong directory. instead it should list drives such as C:\, D:\, E:\ etc if no STORAGE_DIR path is set in config_local.py. This is a regression of RM 1937.

Solution:
we do list drives, If platform is Windows and If self.dir is set to None, but self.dir is set to empty string inside __init__ constructor. This is the reason it wasn't listing drives.
I have taken care it in this patch and tested it for following platforms:
Windows,
Ubuntu and
Mac.

Please find attached patch and review.


Thanks,
Surinder Kumar
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin 4 as Web application
Next
From: Murtuza Zabuawala
Date:
Subject: PATCH: Added user confirmation on panel close (pgAdmin4)