Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable - Mailing list pgadmin-hackers

From Surinder Kumar
Subject Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable
Date
Msg-id CAM5-9D-LoaZ12KrKvup3k4YUmW_Kkv5qR538p=1fwzS6bTftEw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi

Please find updated patch with following changes:
  1. Replaced the outdated code for Backgrid Sizeable Columns plugin with https://github.com/FortesSolutions/backgrid-sizeable-columns library because the updated code is available here.
  2. I have figured out to calculate offset using the parameters of listener provided, so we need not to tweak the original library code.

On Fri, May 27, 2016 at 5:00 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:


On Fri, May 27, 2016 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Added support for Columns resizable in query tool. It allows user to resize
> the table columns as much as needed.
>
> We are using Backgrid Sizeable Columns plugin:
> https://github.com/WRidder/backgrid-sizeable-columns
>
> with one change in library on line no 185:
> moved the following trigger event out of if condition:
>
> if (newWidth != oldWidth) {
>
> }
>
>
> and added one additional parameter offset.
> //Trigger event
>
> view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);
>
>
> We are listening to this trigger event in sqleditor.js file where we need
> offset
> to calculate new table width on every resize event.

Please ensure any changes to third party libraries are submitted upstream.
yes, sure. 

> hence, here is the patch attached.

ENOATTACHMENT!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachment

pgadmin-hackers by date:

Previous
From: Sandeep Thakkar
Date:
Subject: Re: Patch for pgAdmin4 RPM package
Next
From: Dave Page
Date:
Subject: Re: Patch for pgAdmin4 RPM package