[pgAdmin4][Patch]: CanDrop as a function not working - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][Patch]: CanDrop as a function not working
Date
Msg-id CAM5-9D-G2dJxN6cMbgBmiphagD97PLHKn6-qzUKyEUQH5jaRBQ@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: CanDrop as a function not working
List pgadmin-hackers
Hi,

Issue: When we delete a node, it gets deleted successfully, but after that it binds each sub-nodes of particular node with canDrop method, then code throws javascript error.

I found that it was caused because canDrop value is set to true by default in delete_obj callback(node.js), so the function defined for canDrop does't gets called in the callback.

And, it is regression of commit id: 26aa5607ad8eb92591e732837e6aa1a0c48f62b3 which was introduced for Server-group drop functionality. The way it was coded was wrong. so, I have fixed the issue related to "Fix dropping of server groups" in this patch.
Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixed misc issues
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Resolved an issue about missing 'canDrop' function ch