Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: CanDrop as a function not working - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [pgAdmin4][Patch]: CanDrop as a function not working
Date
Msg-id CAG7mmoxNYzwjY1z7xeMcGe0HT_MwvbPpHxixBA5ObdpuvwOHNw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: CanDrop as a function not working  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Mon, May 16, 2016 at 8:11 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Issue: When we delete a node, it gets deleted successfully, but after that it binds each sub-nodes of particular node with canDrop method, then code throws javascript error.

I found that it was caused because canDrop value is set to true by default in delete_obj callback(node.js), so the function defined for canDrop does't gets called in the callback.

And, it is regression of commit id: 26aa5607ad8eb92591e732837e6aa1a0c48f62b3 which was introduced for Server-group drop functionality. The way it was coded was wrong. so, I have fixed the issue related to "Fix dropping of server groups" in this patch.


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Resolved an issue about missing 'canDrop' function ch
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Link online help to dialogs