Re: nodes/*funcs.c inconsistencies - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: nodes/*funcs.c inconsistencies
Date
Msg-id CAM3SWZT_Ugujtcmn+Zq97u5GPcdL1UGMEQxoUKaxZE46-eAtDA@mail.gmail.com
Whole thread Raw
In response to Re: nodes/*funcs.c inconsistencies  (Noah Misch <noah@leadboat.com>)
Responses Re: nodes/*funcs.c inconsistencies  (Peter Geoghegan <pg@heroku.com>)
Re: nodes/*funcs.c inconsistencies  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Sun, Aug 2, 2015 at 1:28 PM, Noah Misch <noah@leadboat.com> wrote:
> A fresh audit found the attached problems new in 9.5[1].  Most are cosmetic
> INT/UINT or field order corrections.

I was responsible for a couple of the cosmetic ones. Sorry about that.

It occurs to me that we could do a little more to prevent this
automatically. Couldn't we adopt
AssertVariableIsOfType()/AssertVariableIsOfTypeMacro() to macros like
READ_UINT_FIELD()?

I'm surprised that this stuff was only ever used for logical decoding
infrastructure so far.
-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: nodes/*funcs.c inconsistencies
Next
From: Peter Geoghegan
Date:
Subject: Re: nodes/*funcs.c inconsistencies