Re: Free indexed_tlist memory explicitly within set_plan_refs() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date
Msg-id CAM3SWZR2WFn+bgY4R+TchvzQndi9xV=ABpM176n8SuLyy+c_FQ@mail.gmail.com
Whole thread Raw
In response to Re: Free indexed_tlist memory explicitly within set_plan_refs()  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Sun, Jul 12, 2015 at 1:45 PM, Andres Freund <andres@anarazel.de> wrote:
> But that's more crummy API's fault than yours.

As you probably noticed, the only reason the p_is_update and
p_is_insert fields exist is for transformAssignedExpr() -- in fact, in
the master branch, nothing checks the value of p_is_update (although I
suppose a hook into a third-party module could see that module test
ParseState.p_is_update, so that isn't quite true).

> I'm right now not really coming up with a better idea how to fix
> this. So I guess I'll apply something close to this tomorrow.

Sounds good.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Adam Brightwell
Date:
Subject: Re: One question about security label command
Next
From: Noah Misch
Date:
Subject: Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22