Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22 - Mailing list pgsql-hackers

From Noah Misch
Subject Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22
Date
Msg-id 20150712220528.GA1103701@tornado.leadboat.com
Whole thread Raw
In response to Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Sun, Jul 12, 2015 at 05:02:51PM -0400, Andrew Dunstan wrote:
> >>Marco Atzeri <marco.atzeri@gmail.com> writes:
> >>>for what I see the hstore_plperl link has a double problem.
> >>>It requires a link to hstore
> >>>as it also requires a link to perl.
> >>>Attached patch for solving this and a similar issue with python.
> >>>+ifeq ($(PORTNAME), cygwin)
> >>>+# This means we need an in-tree build on Windows, not a pgxs build
> >>>+SHLIB_LINK += -L../hstore -lhstore -L$(perl_archlibexp)/CORE -lperl
> >>>+endif

That's the right general strategy, agreed.

> Unless there is further argument I propose to commit something very like
> Marco's suggestion for hstore_plperl, hstore_plpython and ltree_plpython

Would you post the final patch for review?

Thanks,
nm



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Free indexed_tlist memory explicitly within set_plan_refs()
Next
From: David Fetter
Date:
Subject: Re: creating extension including dependencies