Postgres Pro
Downloads
Home   >   mailing lists

Re: block-level incremental backup - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: block-level incremental backup
Date
Msg-id CAM2+6=WV8_Lp9Fng3o8jKri3Wa21_0oxh6dunE5qdXvSWZQ6SQ@mail.gmail.com
Whole thread Raw
In response to Re: block-level incremental backup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: block-level incremental backup  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
Re: block-level incremental backup  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view


On Mon, Aug 5, 2019 at 7:13 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignesh21@gmail.com> wrote:
> + rc = system(copycmd);

I don't think this patch should be calling system() in the first place.

So, do you mean we should just do fread() and fwrite() for the whole file?

I thought it is better if it was done by the OS itself instead of reading 1GB
into the memory and writing the same to the file.


--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Jeevan Chalke
Technical Architect, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: SegFault on 9.6.14
Next
From: Liudmila Mantrova
Date:
Subject: Re: s/rewinded/rewound/?