On Mon, Aug 5, 2019 at 7:13 PM Robert Haas <robertmhaas@gmail.com> wrote:On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignesh21@gmail.com> wrote:> + rc = system(copycmd);I don't think this patch should be calling system() in the first place.So, do you mean we should just do fread() and fwrite() for the whole file? I thought it is better if it was done by the OS itself instead of reading 1GBinto the memory and writing the same to the file.
On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignesh21@gmail.com> wrote:> + rc = system(copycmd);I don't think this patch should be calling system() in the first place.
-- Robert HaasEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Jeevan ChalkeTechnical Architect, Product DevelopmentEnterpriseDB CorporationThe Enterprise PostgreSQL Company
-- Robert HaasEnterpriseDB: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
pgsql-hackers by date:
Соглашаюсь с условиями обработки персональных данных
