Re: Use fadvise in wal replay - Mailing list pgsql-hackers

From Gregory Stark (as CFM)
Subject Re: Use fadvise in wal replay
Date
Msg-id CAM-w4HNM5WwXxf34KgeYZpmwxeDDvF9H9csg9Q8yhAXz=cmfVA@mail.gmail.com
Whole thread Raw
In response to Re: Use fadvise in wal replay  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Thu, 19 Jan 2023 at 18:19, Andres Freund <andres@anarazel.de> wrote:
>
> On 2023-01-19 22:19:10 +0100, Tomas Vondra wrote:
>
> > So I'm a bit unsure about this patch. I doesn't seem like it can perform
> > better than read-ahead (although perhaps it does, on a different storage
> > system).
>
> I really don't see the point of the patch as-is.
...
> I don't disagree fundamentally. But that doesn't make this patch a useful
> starting point.

It sounds like this patch has gotten off on the wrong foot and is not
worth moving forward to the next commitfest. Hopefully a starting over
from a different approach might target i/o that is more amenable to
fadvise. I'll mark it RwF.

-- 
Gregory Stark
As Commitfest Manager



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Direct I/O
Next
From: Pavel Stehule
Date:
Subject: Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has)