Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] GSoC 2017 weekly progress reports (week 2) - Mailing list pgsql-hackers

From Shubham Barai
Subject Re: [HACKERS] GSoC 2017 weekly progress reports (week 2)
Date
Msg-id CALxAEPtLbHbrH3rVncmXzquaGmi9966BY+6G16mHfKYzYQrgkg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] GSoC 2017 weekly progress reports (week 2)  (Andrew Borodin <borodin@octonica.com>)
Responses Re: [HACKERS] GSoC 2017 weekly progress reports (week 2)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view
Hi,

I have made some changes in tests and pushed them to my branch.

Thanks for helping me out with testing.

Now, current head produces false positives but, with my patch, it doesn't.

Here is the link for updated tests: https://github.com/shubhambaraiss/postgres/commit/2c02685a50a2b30654beb5c52542a57a46219c39

 

Regards,
Shubham



Sent with Mailtrack

On 13 June 2017 at 23:32, Andrew Borodin <borodin@octonica.com> wrote:
2017-06-13 18:00 GMT+05:00 Shubham Barai <shubhambaraiss@gmail.com>:
>
> Project: Explicitly support predicate locks in index AMs besides b-tree
>
Hi, Shubham
Good job!

So, in current HEAD test predicate_gist_2.spec generate false
positives, but with your patch, it does not?
I'd suggest keeping spec tests with your code in the same branch, it's
easier. Also it worth to clean up specs style and add some words to
documentation.

Kevin, all, how do you think, is it necessary to expand these tests
not only on Index Only Scan, but also on Bitmap Index Scan? And may be
KNN version of scan too?
I couldn't find such tests for B-tree, do we have them?

Best regards, Andrey Borodin, Octonica.

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] outfuncs.c utility statement support
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] WIP: Data at rest encryption