Re: Compilation issue on Solaris. - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: Compilation issue on Solaris.
Date
Msg-id CALtqXTfJs6=-iT8psFRR7vDm5hD12yY55S-6aBe7RKuM-GhqXw@mail.gmail.com
Whole thread Raw
In response to Re: Compilation issue on Solaris.  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers


On Tue, Sep 6, 2022 at 9:24 AM John Naylor <john.naylor@enterprisedb.com> wrote:
On Sun, Jul 10, 2022 at 9:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Thomas Munro <thomas.munro@gmail.com> writes:
> > Something bothers me about adding yet more clutter to every compile
> > line for the rest of time to solve a problem that exists only for
> > unpatched systems, and also that it's not even really a Solaris thing,
> > it's a C11 thing.
>
> I tend to agree with this standpoint: if it's only a warning, and
> it only appears in a small range of not-up-to-date Solaris builds,
> then a reasonable approach is "update your system if you don't want
> to see the warning".
>
> A positive argument for doing nothing is that there's room to worry
> whether -D__STDC_WANT_LIB_EXT1__ might have any side-effects we
> *don't* want.

This is still listed in the CF as needing review, so I went and marked
it rejected.

+1, Thanks  
--
John Naylor
EDB: http://www.enterprisedb.com


--
Ibrar Ahmed

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Modernizing our GUC infrastructure
Next
From: Ibrar Ahmed
Date:
Subject: Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row