Postgres Pro
Downloads
Home   >   mailing lists

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row
Date
Msg-id CALtqXTeX8H=gGvgJy16E0aWLSk1xwiBQ7OLELFtZ_ujGpHLNEw@mail.gmail.com
Whole thread Raw
In response to Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row  (Naeem Akhter <naeem.akhter@percona.com>)
Responses Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row
List pgsql-hackers
Tree view


On Mon, Aug 1, 2022 at 11:29 PM Naeem Akhter <naeem.akhter@percona.com> wrote:
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Looks good to me.

The new status of this patch is: Ready for Committer
 
The patch has a compilation error on the latest code base, please rebase your patch.
 
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:27: error: ‘result’ was not declared in this scope
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
[03:08:46.087] | ^~~~~~
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:40: error: expected primary-expression before ‘scanbuflen’
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
...

--
Ibrar Ahmed

pgsql-hackers by date:

Previous
From: Ibrar Ahmed
Date:
Subject: Re: Compilation issue on Solaris.
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE