Re: indentation in _hash_pgaddtup() - Mailing list pgsql-hackers

From Ted Yu
Subject Re: indentation in _hash_pgaddtup()
Date
Msg-id CALte62wCJ1N8t7On8LeJfoaDrH72bqPOVvqX-hcC_ut_ynbypg@mail.gmail.com
Whole thread Raw
In response to Re: indentation in _hash_pgaddtup()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: indentation in _hash_pgaddtup()
List pgsql-hackers


On Thu, Nov 24, 2022 at 12:31 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
David Rowley <dgrowleyml@gmail.com> writes:
> After running pgindent on v2, I see it still pushes the lines out
> quite far. If I add a new line after PageGetItemId(page, and put the
> variable assignment away from the variable declaration then it looks a
> bit better. It's still 1 char over the limit.

If you wanted to be hard-nosed about 80 character width, you could
pull out the PageGetItemId call into a separate local variable.
I wasn't going to be quite that picky, but I won't object if that
seems better to you.

                        regards, tom lane

Patch v4 stores ItemId in a local variable. 
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: indentation in _hash_pgaddtup()
Next
From: Peter Smith
Date:
Subject: Re: Time delayed LR (WAS Re: logical replication restrictions)