Postgres Pro
Downloads
Home   >   mailing lists

Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly
Date
Msg-id CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com
Whole thread Raw
Responses Re: Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
Hi,

It looks like assign_checkpoint_completion_target() is defined [1],
but never used, because of which CheckPointSegments may miss to
account for changed checkpoint_completion_target. I'm attaching a tiny
patch to fix this.

Thoughts?

[1]
commit 88e982302684246e8af785e78a467ac37c76dee9
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:   Mon Feb 23 18:53:02 2015 +0200

    Replace checkpoint_segments with min_wal_size and max_wal_size.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Exit walsender before confirming remote flush in logical replication
Next
From: Bharath Rupireddy
Date:
Subject: Make IsInstallXLogFileSegmentActive() an assert-only function