Postgres Pro
Downloads
Home   >   mailing lists

Re: Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly
Date
Msg-id Y8ZHyQWmYMAsDcQ1@paquier.xyz
Whole thread Raw
In response to Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Dec 26, 2022 at 06:12:34PM +0530, Bharath Rupireddy wrote:
> It looks like assign_checkpoint_completion_target() is defined [1],
> but never used, because of which CheckPointSegments may miss to
> account for changed checkpoint_completion_target. I'm attaching a tiny
> patch to fix this.
>
> Thoughts?

Oops.  It looks like you are right here.  This would impact the
calculation of CheckPointSegments on reload when
checkpoint_completion_target is updated.  This is wrong since we've
switched to max_wal_size as of 88e9823, so this had better be
backpatched all the way down.

Thoughts?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
Next
From: Tom Lane
Date:
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates