Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c) - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Date
Msg-id CALj2ACWfLSo77qmAUE6O4_N6fYpS-3qX8EeFmAFrVZAX_xGqiA@mail.gmail.com
Whole thread Raw
In response to Fix typo with logical connector (src/backend/commands/vacuumparallel.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
List pgsql-hackers
Tree view 
On Fri, Aug 19, 2022 at 5:35 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi,
>
> At function parallel_vacuum_process_all_indexes there is
> a typo with a logical connector.
>
> I think that correct is &&, because both of the operators are
> bool types [1].
>
> As a result, parallel vacuum workers can be incorrectly enabled.
>
> Attached a trivial fix.
>
> [1] https://wiki.sei.cmu.edu/confluence/display/c/EXP46-C.+Do+not+use+a+bitwise+operator+with+a+Boolean-like+operand

Good catch! Patch LGTM.

-- 
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Next
From: Bharath Rupireddy
Date:
Subject: Fix a comment in WalSnd structure