Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c) - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Date
Msg-id CAA4eK1JX2txZ2qmtDn6OofdUiRe4HbUHbPBkdbXgwkhaBz9wLA@mail.gmail.com
Whole thread Raw
In response to Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
On Fri, Aug 19, 2022 at 5:40 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Fri, Aug 19, 2022 at 5:35 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
> >
> > Hi,
> >
> > At function parallel_vacuum_process_all_indexes there is
> > a typo with a logical connector.
> >
> > I think that correct is &&, because both of the operators are
> > bool types [1].
> >
> > As a result, parallel vacuum workers can be incorrectly enabled.
> >
> > Attached a trivial fix.
> >
> > [1]
https://wiki.sei.cmu.edu/confluence/display/c/EXP46-C.+Do+not+use+a+bitwise+operator+with+a+Boolean-like+operand
>
> Good catch! Patch LGTM.
>

+1. This looks fine to me as well. I'll take care of this early next
week unless someone thinks otherwise.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Fix a comment in WalSnd structure
Next
From: David Geier
Date:
Subject: Re: Reducing planning time on tables with many indexes