Postgres Pro
Downloads
Home   >   mailing lists

Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Date
Msg-id CALj2ACWYMfGeiRy23tQAPgRHHrzC72q8Ynr4HUksfUa2ywBT3w@mail.gmail.com
Whole thread Raw
In response to Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
List pgsql-hackers
Tree view 
On Wed, Jun 2, 2021 at 11:43 AM Peter Smith <smithpb2250@gmail.com> wrote:
> Yes, it looks better, but (since the masks are all 1 bit) I was only
> asking why not do like:
>
> if (supported_opts & SUBOPT_CONNECT)
> if (supported_opts & SUBOPT_ENABLED)
> if (supported_opts & SUBOPT_SLOT_NAME)
> if (supported_opts & SUBOPT_COPY_DATA)

Please review the attached v3 patch further.

With Regards,
Bharath Rupireddy.
Attachment

pgsql-hackers by date:

Previous
From: "Joe Wildish"
Date:
Subject: Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers
Next
From: "Joel Jacobson"
Date:
Subject: Re: security_definer_search_path GUC