Postgres Pro
Downloads
Home   >   mailing lists

Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Date
Msg-id CALj2ACVWyJNV_JiErv-FbH9ySqAskyho3CP5-mZazbhrJb-kgQ@mail.gmail.com
Whole thread Raw
In response to Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view
On Wed, Jun 2, 2021 at 6:11 PM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Wed, Jun 2, 2021 at 11:43 AM Peter Smith <smithpb2250@gmail.com> wrote:
> > Yes, it looks better, but (since the masks are all 1 bit) I was only
> > asking why not do like:
> >
> > if (supported_opts & SUBOPT_CONNECT)
> > if (supported_opts & SUBOPT_ENABLED)
> > if (supported_opts & SUBOPT_SLOT_NAME)
> > if (supported_opts & SUBOPT_COPY_DATA)
>
> Please review the attached v3 patch further.

Added it to the commitfeset - https://commitfest.postgresql.org/33/3151/

With Regards,
Bharath Rupireddy.

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: A few random typos in the docs
Next
From: Bharath Rupireddy
Date:
Subject: Re: Are we missing (void) when return value of fsm_set_and_search is ignored?