Re: Fix a typo in pgstatfuncs.c - Mailing list pgsql-hackers

On Wed, Aug 10, 2022 at 1:22 PM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>
> Hi,
>
> It seems like there's the following typo in pgstatfuncs.c:
>
> -               /* Values only available to role member or
> pg_read_all_stats */
> +               /* Values only available to role member of
> pg_read_all_stats */
>
> Attaching a tiny patch to fix it.

I don't think it's a typo, the comment says that the values are only
available to the user who has privileges of backend's role or
pg_read_all_stats, the macro HAS_PGSTAT_PERMISSIONS says it all.

IMO, any of the following works better, if the existing comment is confusing:

        /* Values only available to the member{or role or user} with
privileges of backend's role or pg_read_all_stats */

        /* Values only available to the member{or role or user} that
has membership in backend's role or has privileges of
pg_read_all_stats */

--
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/