Re: Fix a typo in pgstatfuncs.c - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: Fix a typo in pgstatfuncs.c
Date
Msg-id 738d6dcd-1e7b-d61a-9832-4659bd5676e7@amazon.com
Whole thread Raw
In response to Re: Fix a typo in pgstatfuncs.c  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Hi,

On 8/10/22 10:30 AM, Bharath Rupireddy wrote:
> On Wed, Aug 10, 2022 at 1:22 PM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>> Hi,
>>
>> It seems like there's the following typo in pgstatfuncs.c:
>>
>> -               /* Values only available to role member or
>> pg_read_all_stats */
>> +               /* Values only available to role member of
>> pg_read_all_stats */
>>
>> Attaching a tiny patch to fix it.
> I don't think it's a typo, the comment says that the values are only
> available to the user who has privileges of backend's role or
> pg_read_all_stats, the macro HAS_PGSTAT_PERMISSIONS says it all.

Looking at HAS_PGSTAT_PERMISSIONS, i think you are right: sorry for the 
noise.

Thanks!

Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com




pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Next
From: Daniel Gustafsson
Date:
Subject: Small typo in OAT README