Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). - Mailing list pgsql-committers

From Bharath Rupireddy
Subject Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
Date
Msg-id CALj2ACVjm8rMzv5ij+Uif3E3iXxnFEH3_B5ptEoo9U3EFJPd=A@mail.gmail.com
Whole thread Raw
In response to pgsql: Allow GRANT on pg_log_backend_memory_contexts().  (Jeff Davis <jdavis@postgresql.org>)
List pgsql-committers
On Wed, Oct 27, 2021 at 10:33 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Oct 27, 2021 at 10:27:18AM +0530, Bharath Rupireddy wrote:
> > +1 and the above statement looks good. Apart from that I have one more
> > suggestion that I earlier made: have the function produce the error
> > when no permissions were granted (just to ensure we have the error
> > message covered) including has_function_privilege() case.
>
> has_function_privilege() makes sure of the same thing, so I think that
> what Jeff has done for this part is just but fine.  There is no need
> for more duplication in the tests.

Fair enough.

Regards,
Bharath Rupireddy.



pgsql-committers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
Next
From: Michael Paquier
Date:
Subject: pgsql: Add test for copy of shared dependencies from template database