Postgres Pro
Downloads
Home   >   mailing lists

Re: Implement generalized sub routine find_in_log for tap test - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Implement generalized sub routine find_in_log for tap test
Date
Msg-id CALj2ACVQovWdxd1C9K86JAtG4mTbh86qqXfKHjWw0BeLXAHE3g@mail.gmail.com
Whole thread Raw
In response to Re: Implement generalized sub routine find_in_log for tap test  (vignesh C <vignesh21@gmail.com>)
Responses Re: Implement generalized sub routine find_in_log for tap test  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Mon, Jun 5, 2023 at 9:39 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Sun, 4 Jun 2023 at 03:51, Michael Paquier <michael@paquier.xyz> wrote:
> >
> > This looks like a typo to me, the log offset is eaten.
> >
> > Except of that, I am on board with log_contains().
>
> Thanks for fixing this.

+1 for deduplicating find_in_log. How about deduplicating advance_wal
too so that 019_replslot_limit.pl, 033_replay_tsp_drops.pl,
035_standby_logical_decoding.pl and 001_stream_rep.pl can benefit
immediately?

FWIW, a previous discussion related to this is here
https://www.postgresql.org/message-id/flat/CALj2ACVUcXtLgHRPbx28ZQQyRM6j%2BeSH3jNUALr2pJ4%2Bf%3DHRGA%40mail.gmail.com.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Alexander Pyhalov
Date:
Subject: Re: Partial aggregates pushdown
Next
From: John Naylor
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum