On Mon, Oct 25, 2021 at 4:36 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> On 2021/10/25 16:44, Bharath Rupireddy wrote:
> > Yeah, let's focus on fixing the hint message here and the
> > alter_foreign_data_wrapper_options_v3.patch LGTM.
>
> Thanks! But since v3 changed the error codes, I got rid of those
> changes and made v4 patch. Attached.
That's okay as we plan to deal with the error code stuff separately.
> > Why didn't we have a test case for file_fdw? It looks like the
> > file_fdw contrib module doesn't have any test cases in its sql
> > directory. I'm not sure if the module code is being covered in
> > someother tests.
>
> You can see the regression test for file_fdw,
> in contrib/file_fdw/input and output directories.
I missed it. Thanks. I see that there are already test cases covering
error message with hint - "There are no valid options in this
context."
The v4 patch LGTM.
Regards,
Bharath Rupireddy.
