Postgres Pro
Downloads
Home   >   mailing lists

Re: Improve the HINT message of the ALTER command for postgres_fdw - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Improve the HINT message of the ALTER command for postgres_fdw
Date
Msg-id 29298fbf-6aec-7700-5cff-74e21d5d0e2e@oss.nttdata.com
Whole thread Raw
In response to Re: Improve the HINT message of the ALTER command for postgres_fdw  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Improve the HINT message of the ALTER command for postgres_fdw
List pgsql-hackers
Tree view 

On 2021/10/25 16:44, Bharath Rupireddy wrote:
> Yeah, let's focus on fixing the hint message here and the
> alter_foreign_data_wrapper_options_v3.patch LGTM.

Thanks! But since v3 changed the error codes, I got rid of those
changes and made v4 patch. Attached.

> Why didn't we have a test case for file_fdw? It looks like the
> file_fdw contrib module doesn't have any test cases in its sql
> directory. I'm not sure if the module code is being covered in
> someother tests.

You can see the regression test for file_fdw,
in contrib/file_fdw/input and output directories.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better
Next
From: Amit Kapila
Date:
Subject: Re: Next Steps with Hash Indexes