Re: Parallel Inserts in CREATE TABLE AS - Mailing list pgsql-hackers

On Wed, Dec 30, 2020 at 5:22 AM Zhihong Yu <zyu@yugabyte.com> wrote:
> w.r.t. v17-0004-Enable-CTAS-Parallel-Inserts-For-Append.patch
>
> + * Push the dest receiver to Gather node when it is either at the top of the
> + * plan or under top Append node unless it does not have any projections to do.
>
> I think the 'unless' should be 'if'. As can be seen from the body of the method:
>
> +       if (!ps->ps_ProjInfo)
> +       {
> +           GatherState *gstate = (GatherState *) ps;
> +
> +           parallel = true;

Thanks. Modified it in the 0004 patch. Attaching v18 patch set. Note
that no change in 0001 to 0003 patches from v17.

Please consider v18 patch set for further review.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com