Postgres Pro
Downloads
Home   >   mailing lists

Re: Parallel Inserts in CREATE TABLE AS - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: Parallel Inserts in CREATE TABLE AS
Date
Msg-id CALNJ-vRMU+7w01=grs7gF5oXFPpUedoLAdf2TgFnDtiUGp+72w@mail.gmail.com
Whole thread Raw
In response to Re: Parallel Inserts in CREATE TABLE AS  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Parallel Inserts in CREATE TABLE AS
List pgsql-hackers
Tree view
w.r.t. v17-0004-Enable-CTAS-Parallel-Inserts-For-Append.patch

+ * Push the dest receiver to Gather node when it is either at the top of the
+ * plan or under top Append node unless it does not have any projections to do.

I think the 'unless' should be 'if'. As can be seen from the body of the method:

+       if (!ps->ps_ProjInfo)
+       {
+           GatherState *gstate = (GatherState *) ps;
+
+           parallel = true;

Cheers

On Mon, Dec 28, 2020 at 4:12 AM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
On Mon, Dec 28, 2020 at 10:46 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> Thanks for working on this, I will have a look at the updated patches soon.

Attaching v17 patch set after addressing comments raised in other
threads. Please consider this patch set for further review.


With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: create table like: ACCESS METHOD
Next
From: Andres Freund
Date:
Subject: Re: Lazy JIT IR code generation to increase JIT speed with partitions