Postgres Pro
Downloads
Home   >   mailing lists

Re: Inconsistency between table am callback and table function names - Mailing list pgsql-hackers

From Ashwin Agrawal
Subject Re: Inconsistency between table am callback and table function names
Date
Msg-id CALfoeitycYHAVsB=ji-9xSyfoS_zf6tPC5EG=T-dystpqcdG_g@mail.gmail.com
Whole thread Raw
In response to Re: Inconsistency between table am callback and table function names  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view

On Thu, May 23, 2019 at 4:32 PM Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2019-05-14 12:11:46 -0700, Ashwin Agrawal wrote:
> Thank you. Please find the patch to rename the agreed functions. It would
> be good to make all consistent instead of applying exception to three
> functions but seems no consensus on it. Given table_ api are new, we could
> modify them leaving systable_ ones as is, but as objections left that as is.

I've pushed a slightly modified version (rebase, some additional
newlines due to the longer function names) now. Thanks for the patch!

Thanks a lot Andres. With pg_intend run before the patch on master, I can imagine possibly generated additional work for you on this.

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Read-only access to temp tables for 2PC transactions
Next
From: Joe Conway
Date:
Subject: Re: Excessive memory usage in multi-statement queries w/ partitioning