Re: Pluggable Storage - Andres's take - Mailing list pgsql-hackers

From Ashwin Agrawal
Subject Re: Pluggable Storage - Andres's take
Date
Msg-id CALfoeis=ha=oyqHoBd0vqBpi+7pgyBmyh89ABbvWmS00wBgz8w@mail.gmail.com
Whole thread Raw
In response to Re: Pluggable Storage - Andres's take  (Andres Freund <andres@anarazel.de>)
Responses Re: Pluggable Storage - Andres's take
Re: Pluggable Storage - Andres's take
List pgsql-hackers
Hi,

While playing with the tableam, usage of which starts with commit v12-0023-tableam-Introduce-and-use-begin-endscan-and-do-i.patch, should we check for NULL function pointer before actually calling the same and ERROR out instead as NOT_SUPPORTED or something on those lines.

Understand its kind of think which should get caught during development. But still currently it segfaults if missing to define some AM function, might be easier for iterative development to error instead in common place.

Or should there be upfront check for NULL somewhere if all the AM functions are mandatory to have functions defined for them and should not be NULL.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Patch to document base64 encoding
Next
From: David Rowley
Date:
Subject: Re: Update does not move row across foreign partitions in v11