Re: tab complete for COPY populated materialized view TO - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: tab complete for COPY populated materialized view TO
Date
Msg-id CALdSSPgYeg=NUbRJxP_nHW5B8vv22jH7P_uZdmxCP+kuoWN8ag@mail.gmail.com
Whole thread Raw
In response to Re: tab complete for COPY populated materialized view TO  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: tab complete for COPY populated materialized view TO
List pgsql-hackers
On Wed, 9 Apr 2025 at 14:45, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
>
>
> On 2025/04/09 18:25, Kirill Reshke wrote:
> > On Wed, 9 Apr 2025 at 13:23, jian he <jian.universality@gmail.com> wrote:
> >>
> >> hi.
> >>
> >> we allow the "COPY table TO" command to copy rows from materialized
> >> views in [1].
> >> The attached patch is to add a tab complete for it.
> >>
> >> [1] https://git.postgresql.org/cgit/postgresql.git/commit/?id=534874fac0b34535c9a5ab9257d6574f78423578
> >
> > Hi!
> > Patch works good for me, but I noticed that psql COPY <tab> suggests
> > partitioned relation both with and without this patch. Maybe that's
> > not a big problem, if [0] will be pushed.
>
> Is the partitioned table currently tab-completed for the COPY FROM case?

If I'm not mistaken, yes. I double checked.

> INSTEAD OF INSERT triggers - though maybe that's overkill?

That's wild to me, psql tab completions feature designed to support
postgresql not fully, but in frequent cases. So maybe we should keep
it stupud.

-- 
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Make cancel request keys longer