Re: Add Boolean node - Mailing list pgsql-hackers

For buildDefItem():

+       if (strcmp(val, "true") == 0)
+           return makeDefElem(pstrdup(name),
+                              (Node *) makeBoolean(true),
+                              -1);
+       if (strcmp(val, "false") == 0)

Should 'TRUE' / 'FALSE' be considered above ?

-       issuper = intVal(dissuper->arg) != 0;
+       issuper = boolVal(dissuper->arg) != 0;

Can the above be written as (since issuper is a bool):