On 2021/12/28 9:32, Masahiko Sawada wrote:
> Doesn't this query return 64? So the expression "substring(str for
> (SELECT max_identifier_length FROM pg_control_init()))" returns the
> first 64 characters of the given string while the application_name is
> truncated to be 63 (NAMEDATALEN - 1) characters. It also seems to be
> fine to use current_setting('max_identifier_length') instead of
> max_identifier_length of pg_control_init().
Interesting! I agree that current_setting('max_identifier_length') should be used instead. Attached is the updated
versionof the patch. It uses current_setting('max_identifier_length').
BTW it seems confusing that pg_control_init() (also pg_controldata) and GUC report different values as
max_identifier_length.Probably they should return the same value such as NAMEDATALEN - 1. But this change might be
overkill...
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
