Re: Partial aggregates pushdown - Mailing list pgsql-hackers

From Zhihong Yu
Subject Re: Partial aggregates pushdown
Date
Msg-id CALNJ-vSm6z6Lg1CgxbGUG6=xP3n+tYC_XGGUm33b9g98Z3bF-g@mail.gmail.com
Whole thread Raw
In response to Re: Partial aggregates pushdown  (Alexander Pyhalov <a.pyhalov@postgrespro.ru>)
Responses Re: Partial aggregates pushdown
List pgsql-hackers


On Sun, Jan 16, 2022 at 11:47 PM Alexander Pyhalov <a.pyhalov@postgrespro.ru> wrote:
Julien Rouhaud писал 2022-01-14 15:16:
> Hi,
>
> On Mon, Nov 15, 2021 at 04:01:51PM +0300, Alexander Pyhalov wrote:
>>
>> I've updated patch - removed catversion dump.
>
> This version of the patchset doesn't apply anymore:
>
> http://cfbot.cputube.org/patch_36_3369.log
> === Applying patches on top of PostgreSQL commit ID
> 025b920a3d45fed441a0a58fdcdf05b321b1eead ===
> === applying patch ./0001-Partial-aggregates-push-down-v07.patch
> patching file src/bin/pg_dump/pg_dump.c
> Hunk #1 succeeded at 13111 (offset -965 lines).
> Hunk #2 FAILED at 14167.
> Hunk #3 succeeded at 13228 (offset -961 lines).
> Hunk #4 succeeded at 13319 (offset -966 lines).
> 1 out of 4 hunks FAILED -- saving rejects to file
> src/bin/pg_dump/pg_dump.c.rej
>
> Could you send a rebased version?  In the meantime I will switch the cf
> entry
> to Waiting on Author.

Hi. Attaching rebased patch.
--
Best regards,
Alexander Pyhalov,
Postgres Professional
Hi,
+   FdwScanPrivateConvertors

+ * Generate attinmeta if there are some converters:

I think it would be better if converter is spelled the same way across the patch.

For build_conv_list():

+   if (IS_UPPER_REL(foreignrel))

You can return NIL for !IS_UPPER_REL(foreignrel) - this would save indentation for the body of the func.

Cheers 

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Extensible Rmgr for Table AMs
Next
From: Jeff Davis
Date:
Subject: Re: Logical insert/update/delete WAL records for custom table AMs