Re: Partial aggregates pushdown - Mailing list pgsql-hackers

From Alexander Pyhalov
Subject Re: Partial aggregates pushdown
Date
Msg-id 2ad047732a8b8a9aaaad06fef59fb283@postgrespro.ru
Whole thread Raw
In response to Re: Partial aggregates pushdown  (Zhihong Yu <zyu@yugabyte.com>)
Responses Re: Partial aggregates pushdown
List pgsql-hackers
Zhihong Yu писал 2022-01-17 11:43:
> Hi,
> +   FdwScanPrivateConvertors
> 
> + * Generate attinmeta if there are some converters:
> 
> I think it would be better if converter is spelled the same way across
> the patch.
> 
> For build_conv_list():
> 
> +   if (IS_UPPER_REL(foreignrel))
> 
> You can return NIL for !IS_UPPER_REL(foreignrel) - this would save
> indentation for the body of the func.

Hi.
Updated patch.

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: New developer papercut - Makefile references INSTALL
Next
From: Alexander Pyhalov
Date:
Subject: Re: Partial aggregates pushdown