Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE - Mailing list pgsql-hackers

From vignesh C
Subject Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
Date
Msg-id CALDaNm3oLHTPJbtn3GQAQ+ki29HRf=JB3r6RfAN5u2ezn0N5Yw@mail.gmail.com
Whole thread Raw
In response to Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
List pgsql-hackers
On Tue, 22 Nov 2022 at 05:59, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> > Those also should be handled, attached v2 version includes the changes
> > for the same.
>
> The basic options supported by PROCEDURE are a subset of ROUTINE with a
> difference of COST, IMMUTABLE, [NOT] LEAKPROOF, ROWS, STABLE
> and VOLATILE.
>
> The basic options supported by ROUTINE are a subset of FUNCTION with a
> difference of { CALLED | RETURNS NULL } ON NULL INPUT, STRICT and
> SUPPORT.  Is it worth refactoring a bit with common lists?

Modified

> +       "RESET", "RETURNS NULL ON NULL INPUT ", "ROWS",
> Extra space after INPUT here, that's easy to miss.

Good catch, the attached v3 patch has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: "Bagga, Rishu"
Date:
Subject: Re: SLRUs in the main buffer pool - Page Header definitions
Next
From: Bharath Rupireddy
Date:
Subject: Re: Split index and table statistics into different types of stats