Postgres Pro
Downloads
Home   >   mailing lists

Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE - Mailing list pgsql-hackers

From Melih Mutlu
Subject Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE
Date
Msg-id CAGPVpCTrRDho5xguMbsro-BhHoz94BLC52JXgzGWGPKFnTVcQg@mail.gmail.com
Whole thread Raw
In response to Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE  (vignesh C <vignesh21@gmail.com>)
Responses Re: Improve tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Tree view
Hi Vignesh,

Looks like the patch needs a rebase.

Also one little suggestion:

+ if (ends_with(prev_wd, ')'))
+ COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
+  "RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT");

What do you think about gathering FUNCTION options as you did with ROUTINE options. 
Something like the following would seem nicer, I think.

#define Alter_function_options \
Alter_routine_options, "CALLED ON NULL INPUT", \
"RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT"

Best,
--
Melih Mutlu
Microsoft

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Allow placeholders in ALTER ROLE w/o superuser
Next
From: Alvaro Herrera
Date:
Subject: Re: ExecRTCheckPerms() and many prunable partitions