Re: Documentation to upgrade logical replication cluster - Mailing list pgsql-hackers

From vignesh C
Subject Re: Documentation to upgrade logical replication cluster
Date
Msg-id CALDaNm3d4nSurbVDo4a7m=L-2CGq00_LcpbeadADm1LOM7GMiw@mail.gmail.com
Whole thread Raw
In response to Re: Documentation to upgrade logical replication cluster  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Documentation to upgrade logical replication cluster
List pgsql-hackers
On Thu, 22 Feb 2024 at 09:35, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are some minor comments for patch v8-0001.
>
> ======
> doc/src/sgml/glossary.sgml
>
> 1.
> +   <glossdef>
> +    <para>
> +     A set of publisher and subscriber instances with publisher instance
> +     replicating changes to the subscriber instance.
> +    </para>
> +   </glossdef>
>
> /with publisher instance/with the publisher instance/

Modified

> ~~~
>
> 2.
> There are 2 SQL fragments but they are wrapped differently (see
> below). e.g. it is not clear why is the 2nd fragment wrapped since it
> is shorter than the 1st. OTOH, maybe you want the 1st fragment to
> wrap. Either way, consistency wrapping would be better.

Modified

Thanks for the comments, the attached v9 version patch has the changes
for the same.

I have added a commitfest entry for this:
https://commitfest.postgresql.org/47/4848/

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: btree: downlink right separator/HIKEY optimization
Next
From: Daniel Gustafsson
Date:
Subject: Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c