On Thu, 22 Feb 2024 at 09:35, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are some minor comments for patch v8-0001.
>
> ======
> doc/src/sgml/glossary.sgml
>
> 1.
> + <glossdef>
> + <para>
> + A set of publisher and subscriber instances with publisher instance
> + replicating changes to the subscriber instance.
> + </para>
> + </glossdef>
>
> /with publisher instance/with the publisher instance/
Modified
> ~~~
>
> 2.
> There are 2 SQL fragments but they are wrapped differently (see
> below). e.g. it is not clear why is the 2nd fragment wrapped since it
> is shorter than the 1st. OTOH, maybe you want the 1st fragment to
> wrap. Either way, consistency wrapping would be better.
Modified
Thanks for the comments, the attached v9 version patch has the changes
for the same.
I have added a commitfest entry for this:
https://commitfest.postgresql.org/47/4848/
Regards,
Vignesh