Re: Documentation to upgrade logical replication cluster - Mailing list pgsql-hackers

Here are some minor comments for patch v8-0001.

======
doc/src/sgml/glossary.sgml

1.
+   <glossdef>
+    <para>
+     A set of publisher and subscriber instances with publisher instance
+     replicating changes to the subscriber instance.
+    </para>
+   </glossdef>

/with publisher instance/with the publisher instance/

~~~

2.
There are 2 SQL fragments but they are wrapped differently (see
below). e.g. it is not clear why is the 2nd fragment wrapped since it
is shorter than the 1st. OTOH, maybe you want the 1st fragment to
wrap. Either way, consistency wrapping would be better.


postgres=# SELECT slot_name FROM pg_replication_slots WHERE slot_type
= 'logical' AND conflict_reason IS NOT NULL;
 slot_name
-----------
(0 rows)

versus

SELECT count(*) FROM pg_replication_slots WHERE slot_type = 'logical'
AND temporary IS false;

======
Kind Regards,
Peter Smith.
Fujitsu Australia