Re: Added schema level support for publication. - Mailing list pgsql-hackers

From vignesh C
Subject Re: Added schema level support for publication.
Date
Msg-id CALDaNm3DDKQUMrPPRAZVbEZeTSwuu=w8CmiaQpWBvR=Cs+F1OA@mail.gmail.com
Whole thread Raw
In response to RE: Added schema level support for publication.  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
List pgsql-hackers
On Thu, Aug 26, 2021 at 7:52 AM tanghy.fnst@fujitsu.com
<tanghy.fnst@fujitsu.com> wrote:
>
> On Wednesday, August 25, 2021 5:37 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > Attached v21 patch has the changes based on the new syntax and fixes
> > few of the other review comments provided by reviewers.
> >
>
> Thanks for your new patch. I saw the following warning when building, please have a look.
>
> publicationcmds.c: In function ‘ConvertPubObjSpecListToOidList’:
> publicationcmds.c:212:23: warning: ‘prevobjtype’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>     pubobj->pubobjtype = prevobjtype;
>     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~

Thanks for reporting this, I have fixed this in the v22 patch attached at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm1rNDbGwoo0FC9vF1BmueUy__u1ZM5yYOjEQW1Of6zdWQ%40mail.gmail.com

Regards,
VIgnesh



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Proof of concept for GUC improvements
Next
From: Dilip Kumar
Date:
Subject: Re: Separate out FileSet from SharedFileSet (was Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o)