Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum - Mailing list pgsql-hackers

From vignesh C
Subject Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum
Date
Msg-id CALDaNm2rxLMbzxxabaqcg4CedLW8seHnmX1d9T0ACVDGa6S9aA@mail.gmail.com
Whole thread Raw
In response to Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Sat, Jul 4, 2020 at 12:32 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada
> <masahiko.sawada@2ndquadrant.com> wrote:
> >
> > On Fri, 3 Jul 2020 at 17:07, vignesh C <vignesh21@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > While checking through the code I found that  some of the function
> > > parameters in reorderbuffer & vacuumlazy are not used. I felt this
> > > could be removed. I'm not sure if it is kept for future use or not.
> > > Attached patch contains the changes for the same.
> > > Thoughts?
> > >
> >
> > For the part of parallel vacuum change, it looks good to me.
> >
>
> Unlike ReorderBuffer, this change looks fine to me as well.  This is a
> quite recent (PG13) change and it would be good to remove it now.  So,
> I will push this part of change unless I hear any objection in a day
> or so.

Thanks all for your comments, attached patch has the changes that
excludes the changes made in reorderbuffer.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Default setting for enable_hashagg_disk (hash_mem)
Next
From: vignesh C
Date:
Subject: Re: Include access method in listTables output